Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Support Custom Cloud in Microsoft.Azure.Management.ResourceManager.Fluent.AzureEnvironment #1326

Open
2 tasks done
bganapa opened this issue Aug 8, 2022 · 0 comments

Comments

@bganapa
Copy link
Member

bganapa commented Aug 8, 2022

Is your feature request related to a problem? Please describe.
Microsoft.Azure.Management.ResourceManager.Fluent.AzureEnvironment has defined a static list of known environments. This class is heavily used when initializing all resourcemanagement clients. This is making it difficult for other custom azure clouds like AzureStack.

Describe the solution you'd like
Suggest adding a method in this class like GetAzureEnvironmentFromArmEndpoint
We have a similar method in Go SDK - https://github.com/Azure/go-autorest/blob/711dde1b1be6e3a7da75975e08f64e0cafb905a3/autorest/azure/metadata_environment.go#L96

All the needed information to initalize the AzureEnvironment can be read from ARM metadata endpoint itself (the existign hardcoded values can be removed as well)
e.g https://management.azure.com/metadata/endpoints?api-version=1.0
https://management.azure.com/metadata/endpoints?api-version=2019-10-01

Describe alternatives you've considered
defining the method ourselves wherever the client needs to be initialized.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant