Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytic Rules Leads to FPs: Preview - TI map IP entity to Cloud App Events #11272

Open
nicolonsky opened this issue Oct 15, 2024 · 2 comments
Open
Assignees

Comments

@nicolonsky
Copy link

nicolonsky commented Oct 15, 2024

The Analytics Rule: Preview - TI map IP entity to Cloud App Events generates false positives if the MCAS column doesn't contain any IP address but due to the join null / empty values are matched.

https://github.com/Azure/Azure-Sentinel/blob/56d63527e9de3b840307776c999ae96e54e7a80f/Solutions/Threat%20Intelligence/Analytic%20Rules/IPEntity_CloudAppEvents.yaml#L39C65-L39C102

Changing the join to remove empty MCAS IPs should resolve this:

 | join kind=innerunique (
    CloudAppEvents
      // --> Remove empty IPs
      | where isnotempty(IPAddress)
      | where TimeGenerated >= ago(dt_lookBack)
      | extend CloudAppEvents_TimeGenerated = TimeGenerated) on $left.TI_ipEntity == $right.IPAddress
@v-rusraut
Copy link
Contributor

Hi @nicolonsky, Thanks for flagging this issue, we will investigate this issue and get back to you with some updates. Thanks!

@v-rusraut v-rusraut linked a pull request Oct 17, 2024 that will close this issue
@v-rusraut
Copy link
Contributor

Hi @nicolonsky , as you have already raised a PR to fix this, our team is currently reviewing it. Once the PR is merged, we will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants