Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug in bc and kbc (Warp) that emerged after merging 2d and 3d… #83

Closed
wants to merge 2 commits into from

Conversation

hsalehipour
Copy link
Collaborator

… kernels

Contributing Guidelines

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • All pytest tests pass (one was failing before)
  • Simple flow inside 2d duct was failing before with regularized BC and/or with KBC. Now they are working.

Linting and Code Formatting

Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.

To run Ruff, execute the following command from the root of the repository:

ruff check .
  • Ruff passes

@hsalehipour hsalehipour added bug Something isn't working documentation Improvements or additions to documentation labels Oct 24, 2024
@mehdiataei
Copy link
Contributor

mehdiataei commented Oct 24, 2024

This PR does not adhere to contributing guidelines as make multiple unrelated changes.

Additionally, just to clarify, XLB is not an official team or product (please read OSS guidelines at Autodesk). The PYPI release is managed through a personal account, and I am the author of the binary associated with it.

@mehdiataei mehdiataei closed this Oct 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants