Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with new pyvista and minor README changes. #27

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Compatibility with new pyvista and minor README changes. #27

merged 3 commits into from
Dec 8, 2023

Conversation

harrybraviner
Copy link
Contributor

  • Replaced UniformGrid->ImageData for compatibility with new pyvista. This is required to work with pyvista 0.43 onwards. Still works with pyvista 0.40 and later, but not 0.39 or earlier.
  • Fixed missing dependencies (orbax, termcolor) and example path in README.md.

@harrybraviner
Examples path and dependencies
e8d2004
@harrybraviner
pyvista UniformGrid -> ImageData
d7b3b74 
pyvists 0.43.0 renames UniformGrid to ImageData. See pyvista/pyvista#4518 for details.
Renamed all instances of this for compatability with pyvista 0.43.
Works with pyvista back to and including 0.40.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@harrybraviner
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@harrybraviner
Copy link
Contributor Author

recheck

@mehdiataei
Copy link
Contributor

Thanks for the PR.
The dependency is not orbax, but "orbax-checkpoint". Can you make the change?

@harrybraviner
Dependency orbax->orbax-checkpoint
f04790b 
Installing orbax installed orbax-checkpoint, but doing this is
deprecated according to docs. Changed dependency and confirmed this
still works.
@mehdiataei
Copy link
Contributor

Thanks!

@mehdiataei mehdiataei merged commit 2d6b799 into Autodesk:main Dec 8, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrybraviner @mehdiataei