Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creation of ApplicationData folder if it doesn't exist yet #513

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

hmmwhatsthisdo
Copy link
Contributor

@hmmwhatsthisdo hmmwhatsthisdo commented Jul 24, 2024

Description

This PR allows the .NET runtime to create the ApplicationData folder for us, even if it doesn't exist yet.

Motivation and Context

This occurs frequently in serverless environments, where variables like XDG_CONFIG_DIR may be set to non-standard values.

Not providing this flag to GetFolderPath causes it to return an empty string if the folder doesn't exist.

Fixes #512.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@hmmwhatsthisdo hmmwhatsthisdo requested a review from a team as a code owner July 24, 2024 03:07
@lipkau lipkau changed the base branch from develop to release/2.15-alpha July 24, 2024 06:52
Copy link
Member

@lipkau lipkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lipkau lipkau merged commit 2c04d56 into AtlassianPS:release/2.15-alpha Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New-JiraSession fails when ApplicationData folder does not exist yet
2 participants