Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : used pushbullet for notification #133

Open
Hatoris opened this issue Jan 22, 2019 · 1 comment
Open

Enhancement : used pushbullet for notification #133

Hatoris opened this issue Jan 22, 2019 · 1 comment

Comments

@Hatoris
Copy link

Hatoris commented Jan 22, 2019

First of all thank you for this really nice piece of soft, it's really well written and a pleasure to use.

I use your package on my server, with cron for scedulling repost of ads. I know that kijiji sends a email when ads is posted but I wanted something else to avoid recive to many emails.

I forked your repo and add pushbullet api to it. In this way I receive notification with ad title and informations about the post (succeed, failed, remove previous ads ...).

Are you interested that I pull my features in to your repo ?

@ArthurG
Copy link
Owner

ArthurG commented Jun 23, 2019

Sorry for the late reply! I've been focused on other projects recently and haven't been too focused on this project.

I took a look at your repo and noticed that you had a clever implementation for dealing with inexact title matches during ad deletion, I think that is a very handy feature which doesn't add to the existing build/repost user flow. I think that could handle some edge cases. Could you please submit a PR for that into the repo 😃?

About your pushbullet feature, it seems like from the lack of comments on this issue that other people aren't too interested in that feature. I'd say we should keep that out because it adds an extra step to the already confusing flow on ad building. I need to reconsider how to make building ads more intuitive, at which point being able to use pushbullet would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants