Use absolute import to avoid circular imports. #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Apr 26, 2024
| @@ -456,7 +456,7 @@ def __str__(self): | |||
| def message_checksum(msg): | |||
| '''calculate CRC-16/MCRF4XX checksum of the key fields of a message, so we | |||
| can detect incompatible XML changes''' | |||
| from .mavcrc import x25crc | |||
| from pymavlink.generator.mavcrc import x25crc | |||
There was a problem hiding this comment.
how is this circular? mavcrc.py doesn't include this module
There was a problem hiding this comment.
I believe the cause of the issue is I had a partially initialized module due to another python module of the same name.
This fixes it though and is more robust anyways in my opinion
AttributeError: partially initialized module 'mavcrc' has no attribute 'x25crc' (most likely due to a circular import)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to fix #913.
Fixing a circular import on my end.