Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker installation defaults to sudo. #5566

Open
wtokumaru opened this issue Nov 16, 2023 · 3 comments
Open

Docker installation defaults to sudo. #5566

wtokumaru opened this issue Nov 16, 2023 · 3 comments
Assignees

Comments

@wtokumaru
Copy link

wtokumaru commented Nov 16, 2023

The docker installation steps here put you in a container that has sudo: https://ardupilot.org/dev/docs/ros2.html#installation-docker
This contradicts the SITL setup requiring not to be run as root: https://ardupilot.org/dev/docs/building-setup-linux.html#install-some-required-packages

Am still able to install through other workflows, so this is not blocking, but might not be intended.

@Ryanf55
Copy link
Contributor

Ryanf55 commented Nov 16, 2023

This will affect non-ROS2 users also. The default developer dockerfile has the same problem because ArduPilot has users run it as root.

@Ryanf55
Copy link
Contributor

Ryanf55 commented Nov 16, 2023

@khancyr I'd love your input. Do we want ArduPilot devs using docker as root, and make ardupilot scripts capable of running in root, or do we want to add stuff to all our dockerfiles to make them not root?

@khancyr
Copy link
Contributor

khancyr commented Nov 16, 2023

Those docker image where intend for CI not generic usage that is why they are using root user and have minimal stuff.

We should build a better image like the one on ArduPilot repo that have proper permission and generic install step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants