Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve webtools (mainly PID tool) documentation / useability #157

Open
Janno117 opened this issue May 14, 2024 · 1 comment
Open

Improve webtools (mainly PID tool) documentation / useability #157

Janno117 opened this issue May 14, 2024 · 1 comment

Comments

@Janno117
Copy link

In the Filter review tool there's a description of what the tool does and what the tool needs in terms of logging data. If the data isn't present in the uploaded logs, the tool gives an error.

The PID-tool does neither have the text, nor the warning when there's not enough data in the logging. It just doesn't calculate the step-responses.

Proposed solution:
Post a picture of the logging bitmasks with the minimum required logging options selected at the top of each tool.
Alternatively post the parameter values of the needed logging parameter bitmasks with the minimum required options.

@IamPete1
Copy link
Member

I just have not had a chance to add that stuff yet. The step-response is a bit tricky, you can have plenty of data but still not get a result, the data also has to be good quality.

Log bitmask values would be nice, but the values you need a different for each vehicle type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants