Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID error when not set to params #133

Open
dusan19 opened this issue Nov 1, 2023 · 1 comment
Open

ID error when not set to params #133

dusan19 opened this issue Nov 1, 2023 · 1 comment

Comments

@dusan19
Copy link
Contributor

dusan19 commented Nov 1, 2023

In uint8_t Transport::arm_status_check():

if (!g.have_basic_id_info()) { // if there is no basic ID data stored in the parameters give warning. If basic ID data are streamed to RID device, // it will store them in the parameters ret += "ID "; }

but what if options param is set such that OPTIONS_DONT_SAVE_BASIC_ID_TO_PARAMETERS is enabled? Then basic ID would not be stored and there will always be an arm status check error.

@BluemarkInnovations
Copy link
Contributor

@dusan19 Sorry somehow I missed this issue. What you state is not true. If the OPTIONS_DONT_SAVE_BASIC_ID_TO_PARAMETERS is enabled, it will use the Basic ID info that is streamed to the device. Only it is not stored permanently as parameter to the device. So yes you will get an arm status check error, if you do not stream BasicID data to the device and have this option set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants