Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support for passing in a number to the pipe #29

Open
eranation opened this issue Apr 3, 2019 · 0 comments
Open

Feature request: support for passing in a number to the pipe #29

eranation opened this issue Apr 3, 2019 · 0 comments

Comments

@eranation
Copy link

Some IDEAs (latest Intellij) will complain when passing a number to the pipe (since its transform method accepts only a string)

Date's constructor does support passing a number, so in runtime this works. It also passes compilation by the angular template compiler, the only issue is IDEA warning and future risk angular template compiler may fail the compilation based on type checking

Suggested fix in pull request: #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant