Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger change event when value is selected #57

Open
mhamann opened this issue Nov 6, 2015 · 2 comments
Open

Trigger change event when value is selected #57

mhamann opened this issue Nov 6, 2015 · 2 comments

Comments

@mhamann
Copy link

mhamann commented Nov 6, 2015

Presently, it seems that the only way to get a notification when the value of the select view changes is to provide an update method on the parent view. This doesn't work well for a view that has multiple select fields or that wants to follow an orchestrator pattern where the child view knows nothing about and does not attempt to call methods on its parent.

We should provide a change event trigger whenever setValue is called.

@wraithgar
Copy link
Contributor

Seems reasonable, and wouldn't take too much to add.

It could be a little cleaner and easier to see what's happening if the trigger happened in the onChange function right after setValue is called, but this is admittedly bike shedding.

Is this something you're comfortable making a PR for, with a test?

@mhamann
Copy link
Author

mhamann commented Nov 6, 2015

Yep, I can do that. Will try to set aside some time next week to get it written...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants