Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from glog to another log solution? #134

Open
floriankoch opened this issue Apr 17, 2020 · 4 comments
Open

Migrate from glog to another log solution? #134

floriankoch opened this issue Apr 17, 2020 · 4 comments
Labels
enhancement New feature or request golang good first issue Good for newcomers help wanted Extra attention is needed

Comments

@floriankoch
Copy link
Collaborator

floriankoch commented Apr 17, 2020 •
edited by AmitKumarDas
Loading

glog is not maintained since 2016 , and e.g the kubernetes project itself migrated away
They use klog now, seems like more or less a drop in replacement
https://github.com/kubernetes/klog

Should metac migrate away from glog?

If yes, which log solution?
@floriankoch floriankoch added enhancement New feature or request golang question Further information is requested labels Apr 17, 2020
@grzesuav
Copy link
Collaborator

#110

@grzesuav
Copy link
Collaborator

adding as it would be good to have possibility to log in json for usage with elasticsearch

@AmitKumarDas
Copy link
Owner

AmitKumarDas commented Apr 18, 2020 •
edited
Loading

klog should be drop in replacement. Integration tests have them already.
I would vote for klog.

As per this example, it has all the fields needed to output in a structured format.

It will be great if community can experiment klog with json output & post the results here.

@AmitKumarDas AmitKumarDas added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 18, 2020
@floriankoch floriankoch removed the question Further information is requested label Apr 18, 2020
@AmitKumarDas
Copy link
Owner

As discussed, Integration Tests in metac was using klog. This PR makes use of klog with appropriate flags.

@grzesuav grzesuav mentioned this issue Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request golang good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AmitKumarDas @grzesuav @floriankoch