Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional MEMORY LIMIT for sandbox #4450

Open
m9e opened this issue Oct 17, 2024 · 0 comments
Open

Optional MEMORY LIMIT for sandbox #4450

m9e opened this issue Oct 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@m9e
Copy link

m9e commented Oct 17, 2024

What problem or use case are you trying to solve?

I've set up openhands for people to tinker with, and had it do some data analysis flows that eat >200GB of memory and tank the box.

Describe the UX of the solution you'd like

No UX needed, all we really need is like SANDBOX_MEMORY_LIMIT=100g here

Do you have thoughts on the technical implementation?

Yes, launch container if that's set with

MEMORY_LIMIT=100g docker-compose up

or similar

Describe alternatives you've considered

Well, my stopgap was to put a mem limit on the docker cgroup on the host box that would keep docker itself from using >3/4 of the system ram, which at least keeps it responsive to kill a container, which was fine for MY problem but would be a terrible way to implement this in a "real" env.

Additional context

I'd just say I think this makes a ton of sense to have given how there's a good amount of effort to deal with other resource limits (eg, concurrent LLM requests w/out user interaction, max quota/requests/cost, etc)

@m9e m9e added the enhancement New feature or request label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant