Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxItems in document-list not working #5050

Open
loictrichaud opened this issue Sep 4, 2019 · 4 comments
Open

maxItems in document-list not working #5050

loictrichaud opened this issue Sep 4, 2019 · 4 comments
Labels

Comments

@loictrichaud
Copy link
Contributor

Type of issue: (check with "[x]")

  • New feature request
  • Bug
  • Support request
  • Documentation

Current behaviour:
The "maxItems" property of the "DocumentListComponent" component does not work because it is not taken into account.
I want to display the user's favorites but only the first 5.

But in class constructor, you erase "maxItems" with UserPreferenceValues.PaginationSize.

Expected behavior:
We should only see 5 items.

Steps to reproduce the issue:
Put 10 files to your favorites. And test that :
<adf-document-list [currentFolderId]="'-favorites-'" [maxItems]="5"> </adf-document-list>.
It's not working and you will see your 10 files. You sould see only 5 files.

Component name and version:
adf-document-list => version 3.4

Browser and version:

Node version (for build issues):
v10.16.0

New feature request:

@DenysVuika
Copy link
Contributor

Thanks for raising this issue. We will address it in the future releases. Meanwhile, as a workaround, you can use the "app.config.json" file to provide the custom maxItems value.

@DenysVuika DenysVuika added the bug label Sep 4, 2019
@jatinAroraGit
Copy link

Hey there,
I would like to work om this issue.

@DenysVuika
Copy link
Contributor

Hey, @jatinAroraGit, thanks for the help. Feel free to pick it and create a PR with the update

@JanUlrichR
Copy link

JanUlrichR commented Jul 31, 2024

Hey,
I think this was not addressed in the meantime.
I also cannot find the property in the Schema for the app.config.json, so does the workaround work right now ?

I will try to create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants