Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Wrong description in pdf_export_jpeg_quality #310

Open
1 task done
cesarblancg opened this issue Oct 10, 2024 · 2 comments
Open
1 task done

[BUG] Wrong description in pdf_export_jpeg_quality #310

cesarblancg opened this issue Oct 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@cesarblancg
Copy link

cesarblancg commented Oct 10, 2024 •
edited
Loading

Version

1.11.4 Build 99 Play store

What platform are you using?

Android

OS Version

Android 14

What happened?

In the description of the setting ‘jpegQuality’, it states that you can put a 0 to disable compression, but the minimum value is 1.

The key for the description is pdf_export_jpeg_quality and the setting is in this line:

OSS-DocumentScanner/app/components/settings/Settings.svelte

Line 377 in ddf5002

min: 1,

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@cesarblancg cesarblancg added the bug Something isn't working label Oct 10, 2024
farfromrefug added a commit that referenced this issue Oct 12, 2024
@farfromrefug
fix: allow jpegQuality == 0 #310
301a34d
@farfromrefug
Copy link
Collaborator

@cesarblancg thanks a lot it will be fixed in the next version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@farfromrefug @cesarblancg and others