Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to be used in merge queue. #2420

Closed
wants to merge 1 commit into from
Closed

Conversation

programmiri
Copy link
Contributor

@programmiri programmiri commented Apr 26, 2024

Resolves: #2419

Note:
This is more complicated as expected unfortunately, as having a workflow that runs only in the queue is not straightforward.

Currently, what I read up and tested, this is how it should work:

-> workflow is triggered on PR event AND merge_group event
-> jobs only should run when it's really queued (not for e.g. opening a PR)
-> job still needs to be triggered by required checks AND required merge groups

This does not seem to work as expected, though, because while the last test run only merged after the required jobs where done, it seems like on the test-main branch another job failed later. This could have been due to timing though and needs more investigation.

Will keep this Draft open for now, but it's not merge ready yet.

@programmiri
Copy link
Contributor Author

Closing this, as there's currently no time to work on it & the repo is not super active, so we can stay at our current pipeline for now.

@programmiri programmiri deleted the add-merge-queue branch August 30, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Update CI to use merge queue
1 participant