Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LXDUI config gets blown away on upgrade due to being persisted next to the source code #347

Open
strugee opened this issue Feb 5, 2021 · 2 comments

Comments

@strugee
Copy link
Contributor

strugee commented Feb 5, 2021

If you opt to install LXDUI globally (i.e. python3 setup.py install without activating a virtualenv first), configuration files such as auth.conf will be stored in and read from /usr/local/lib/python3.7/dist-packages/LXDUI-<version>-py3.7.egg/conf. This location is not the correct place to store configuration, but even worse, if the administrator runs python3 setup.py install again (e.g. to upgrade LXDUI to a new release), this configuration directory will be silently overwritten with the defaults from upstream.

LXDUI should instead read configuration from /etc - e.g. /etc/lxdui or something like that. auth.conf arguably is state instead of configuration, so maybe it should go in /var/lib (or someplace defined in lxdui.conf) but really almost anywhere is better than where it is now in /usr.

See also the hier(7) and file-hierarchy(7) manpages.

@strugee
Copy link
Contributor Author

strugee commented Feb 14, 2022

@jetroni closed by accident?

@jetroni
Copy link
Contributor

jetroni commented Feb 14, 2022

My bad, this issue was referenced to a PR that was merged and I thought that it was already introduced.

@jetroni jetroni reopened this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants