-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading comment in cparser/StructPassing.ml #318
Comments
Thankfully, at first glance there seems to be no hidden bug. As I understand it, when parsing However, |
You,re right that the comment was written with function definitions in mind (where incomplete structs cannot occur) and doesn't match what happens with function declarations (as in your example). At least a better comment is in order. |
In the case of a struct passing using
SP_split_args
, this code ofcparser/StructPassing.ml
is actually misleadingThe
should not happen
part actually happens for the test in test/regression/struct2.c :This can be tested by replacing
Param_unchanged (*should not happen *)
by afailwith "Should not happen"
, then attempting to compiletest/regression/struct2.c
, on thex86_32-linux
architecture.The text was updated successfully, but these errors were encountered: