From 6d39dd0376e0490c6bc45038e687c28cba181d70 Mon Sep 17 00:00:00 2001 From: ZShunRen Date: Wed, 6 Nov 2024 20:21:20 +0800 Subject: [PATCH 1/3] Update ug to add known issue --- docs/UserGuide.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 20da6e791b0..1c48aca9bb8 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -754,6 +754,7 @@ Each status type is visually distinguished in the UI: Urgent is denoted by a red 1. **When using multiple screens**, if you move the application to a secondary screen, and later switch to using only the primary screen, the GUI will open off-screen. The remedy is to delete the `preferences.json` file created by the application before running the application again. 2. **If you minimize the Help Window** and then run the `help` command (or use the `Help` menu, or the keyboard shortcut `F1`) again, the original Help Window will remain minimized, and no new Help Window will appear. The remedy is to manually restore the minimized Help Window. 3. **When inputting names that use `/`**, this can cause an `invalid command` error to be shown or even unintended attributes for the client added. Avoid using `/`, and spell out the names in full, for cases like 'Ramesh s/o Ravichandran', change it to 'Ramesh Son Of Ravichandran' +4. **Using non-english text input can cause visual bugs**. This release fully supports English text input only**. Using non-English characters or text may cause display issues, including incorrect text direction and character rendering. We are actively working to expand international language support in future releases. -------------------------------------------------------------------------------------------------------------------- From 8a124a3d7a58eba4d284b5514c43bf8940a1f2c8 Mon Sep 17 00:00:00 2001 From: ZShunRen Date: Wed, 6 Nov 2024 20:42:02 +0800 Subject: [PATCH 2/3] Fix inconsistency in new line appending in edit ra/ --- src/main/java/seedu/address/model/client/Remark.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/seedu/address/model/client/Remark.java b/src/main/java/seedu/address/model/client/Remark.java index 1dc777a11bb..dc1800eb01b 100644 --- a/src/main/java/seedu/address/model/client/Remark.java +++ b/src/main/java/seedu/address/model/client/Remark.java @@ -62,7 +62,7 @@ public static Remark combineRemarks(Remark... remarks) { for (Remark currentRemark: remarks) { combinedValues.append(currentRemark.value + "\n"); } - return new Remark(combinedValues.toString()); + return new Remark(combinedValues.toString().trim()); } } From 8e4d180618b81d12d93ba314756ee68a1cef080e Mon Sep 17 00:00:00 2001 From: ZShunRen Date: Wed, 6 Nov 2024 20:44:43 +0800 Subject: [PATCH 3/3] Fix edit command test --- src/test/java/seedu/address/logic/commands/EditCommandTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/seedu/address/logic/commands/EditCommandTest.java b/src/test/java/seedu/address/logic/commands/EditCommandTest.java index 17a228343d6..148e4d2d5b1 100644 --- a/src/test/java/seedu/address/logic/commands/EditCommandTest.java +++ b/src/test/java/seedu/address/logic/commands/EditCommandTest.java @@ -88,7 +88,7 @@ public void execute_appendRemarkFieldsSpecifiedUnfilteredList_success() { ClientBuilder clientInList = new ClientBuilder(lastClient); Client editedClient = clientInList.withName(VALID_NAME_BOB).withPhone(VALID_PHONE_BOB) - .withTier(VALID_TIER_REJECT).withRemark(CommandCommons.DEFAULT_REMARK + "\nTest\n").build(); + .withTier(VALID_TIER_REJECT).withRemark(CommandCommons.DEFAULT_REMARK + "\nTest").build(); EditClientDescriptor descriptor = new EditClientDescriptorBuilder().withName(VALID_NAME_BOB) .withPhone(VALID_PHONE_BOB).withTier(VALID_TIER_REJECT)