Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matching XMLs to Chronobox SEQ_RUNNING hits for very close sequences #36

Open
DJDuque opened this issue Sep 14, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@DJDuque
Copy link
Member

DJDuque commented Sep 14, 2024

The XMLs have a 1s granularity. Currently, they are matched to Chronobox hits by the closest match within a given tolerance. If sequences start running within 1 second, they both match to the same SEQ_RUNNING chronobox hit. This is not a very big issue, because this mostly happens for e.g. rct_botg sequences that don't have an event table. But it might bite us in the future if there is a very quick sequence with an event table run in a loop.

This can be tested with e.g. run 10620

@DJDuque DJDuque added the bug Something isn't working label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant