Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle collinear spacepoints for helix initial guess in track_fitting #95

Open
DJDuque opened this issue Oct 1, 2023 · 0 comments
Open

Comments

@DJDuque
Copy link
Member

DJDuque commented Oct 1, 2023

The current implementation returns a TryTrackFromClusterError::NoInitialParameters error when the 3 initial template points obtained are collinear. This is the case because it is not possible to obtain a circle (with finite radius) that goes through those 3 points in the x/y plane.

A possible solution is to resample the spacepoints to get 3 that are not collinear (and error if this is not possible).
Other possible solution would be to just assign a very large radius for these cases, but on what side of the line would it be best to place the center of the circle? If we pick the wrong side, then the initial guess will be very far off from the actual helix we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant