Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make enable_distsql defaults on #3544

Open
aceforeverd opened this issue Oct 9, 2023 · 0 comments · May be fixed by #3627
Open

make enable_distsql defaults on #3544

aceforeverd opened this issue Oct 9, 2023 · 0 comments · May be fixed by #3627
Assignees
@aceforeverd @lqy222
Labels
bug Something isn't working high-priority test

Comments

@aceforeverd
Copy link
Collaborator

tablet server uses this flag enable_distsql to enable cluster optimization

OpenMLDB/src/tablet/tablet_impl.cc

Lines 210 to 214 in b685e64

if (IsClusterMode()) {
options.SetClusterOptimized(FLAGS_enable_distsql);
} else {
options.SetClusterOptimized(false);
}
. It is on with release configurations: release/conf/tablet.flags.template, but no in src/flags.cc. Which as a results, won't enabled in mini_cluster tests, e.g sql_sdk_test.

There is a PR previously #3295, but turns out breaks existing tests. It means there exists cases that is OK with request mode, but not request(cluster) mode.

#3531 is a example, deployment tests not fail for those tests, simply because enable_distsql not turned on.
@aceforeverd aceforeverd added bug Something isn't working test labels Oct 9, 2023
@aceforeverd aceforeverd self-assigned this Oct 9, 2023
aceforeverd added a commit to aceforeverd/fedb that referenced this issue Nov 24, 2023
@aceforeverd
test(4paradigm#3544): cluster opt default on
6c4805e
@aceforeverd aceforeverd linked a pull request Nov 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aceforeverd aceforeverd

@lqy222 lqy222

Labels
bug Something isn't working high-priority test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(#3544): cluster opt default on aceforeverd/fedb
3 participants
@lumianph @aceforeverd @lqy222