Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance wc/guard-super-call with fix #60

Open
stramel opened this issue May 17, 2021 · 0 comments
Open

Enhance wc/guard-super-call with fix #60

stramel opened this issue May 17, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@stramel
Copy link
Collaborator

stramel commented May 17, 2021

It should be relatively simple to add a fix for wc/guard-super-call

Take a simple error state such as:

connectedCallback() {
  super.connectedCallback();
  this.setAttribute('bar', 'baz');
}

and change it to this:

connectedCallback() {
  if (super.connectedCallback) {
    super.connectedCallback();
  }
  this.setAttribute('bar', 'baz');
}
@stramel stramel added enhancement New feature or request help wanted Extra attention is needed labels May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant