-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG Social link in the footer opening in the same tab #3775
Labels
Comments
Thanks for the ticket! For folks who are reviewing this, consider the accessibility implications before deciding how to address. |
Our accessibility experts have weighed in:
Neither of the cases where it is recommended for accessibility apply to these links, so we should probably leave it as it is. |
Okay , thanks for responding.
Yeah maybe leaving it as it is feels right .
…On Tue, Apr 9, 2024, 22:56 Peter Rowland ***@***.***> wrote:
Our accessibility experts have weighed in:
- Its generally discouraged to open new windows or tabs.
- The cases where it's recommended are for additional context
information or if following the link would take the user away from a logged
in session
- If you are going to do it, there should be advanced warning (with
alt text and an icon)
- see: https://www.w3.org/TR/WCAG20-TECHS/G200.html
Neither of the cases where it is recommended for accessibility apply to
these links, so we should probably leave it as it is.
—
Reply to this email directly, view it on GitHub
<#3775 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2MYN4PIF26H5FL6WNOFKODY4QQEHAVCNFSM6AAAAAA6J3IAUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVG4ZTSMBVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
The social links in the footer should open in new tabs upon clicking them for the best user experience
Actual Behavior
But here these social links in the footer open in the same tab as the current tab making it a hindrance for the user experience as the user has to go back to the site and then proceed after using each social link.
Steps to reproduce the behavior
Image ref below:
This issue is done when
This issue does not have any special triggering event.
PS: I would love to work on a fix for this issue and am open for discussion about the same too.
The text was updated successfully, but these errors were encountered: