Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Social link in the footer opening in the same tab #3775

Closed
tmsagarofficial opened this issue Oct 21, 2023 · 3 comments
Closed

BUG Social link in the footer opening in the same tab #3775

tmsagarofficial opened this issue Oct 21, 2023 · 3 comments
Assignees
Labels

Comments

@tmsagarofficial
Copy link

Expected Behavior

The social links in the footer should open in new tabs upon clicking them for the best user experience

Actual Behavior

But here these social links in the footer open in the same tab as the current tab making it a hindrance for the user experience as the user has to go back to the site and then proceed after using each social link.

Steps to reproduce the behavior

  1. Go to https://18f.gsa.gov
  2. Scroll till you see the footer of the website
  3. Observe that clicking on any of the social links makes it open in the same tab as the current tab.
    Image ref below:
    image

This issue is done when

This issue does not have any special triggering event.

PS: I would love to work on a fix for this issue and am open for discussion about the same too.

@adunkman
Copy link
Member

adunkman commented Mar 1, 2024

Thanks for the ticket! For folks who are reviewing this, consider the accessibility implications before deciding how to address.

@peterrowland
Copy link
Member

Our accessibility experts have weighed in:

  • Its generally discouraged to open new windows or tabs.
  • The cases where it's recommended are for additional context information or if following the link would take the user away from a logged in session
  • If you are going to do it, there should be advanced warning (with alt text and an icon)
  • see: https://www.w3.org/TR/WCAG20-TECHS/G200.html

Neither of the cases where it is recommended for accessibility apply to these links, so we should probably leave it as it is.

@tmsagarofficial
Copy link
Author

tmsagarofficial commented Apr 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants