Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull quotes not showing on blog #3759

Closed
1 task
cmajel opened this issue Sep 22, 2023 · 1 comment · Fixed by #3760
Closed
1 task

Pull quotes not showing on blog #3759

cmajel opened this issue Sep 22, 2023 · 1 comment · Fixed by #3760
Assignees
Labels

Comments

@cmajel
Copy link
Member

cmajel commented Sep 22, 2023

Expected Behavior

To see a styled pull quote on blog posts when indicated. We had these on the older version of the site.

Actual Behavior

Things that were pull quotes in the past are now styled like regular text; see last paragraph in the screenshot of this blog:

Screen Shot 2023-09-22 at 3 17 22 PM

Another example on this post:; see last paragraph in the screenshot:
Screen Shot 2023-09-22 at 3 19 22 PM

Steps to reproduce the behavior

  • [ ]
  • [ ]
  • [ ]

This issue is done when

  • Pull quotes from past blogs don't appear as extra text
  • [ ]
  • [ ]
@igorkorenfeld
Copy link
Member

igorkorenfeld commented Sep 22, 2023

Noting to self or future maintainer:

The current css targets blockquote elements but the quotes in the blog posts here are divs with a "testimonial-blockquote" class.

Ideas for resolving:

  1. Change the quote within the post to a blockquote. In theory this should be doable by placing a ">" in front of the quote. This may be more semantic and would have the styling automatically applied. However, it would mean we would need to edit any post that has "the testimonial-blocquote" in it to resolve all of them.
  2. Add .testimonial-blockquote as a target to the existing blockquote styles declarations in the blog.scss style file. This should then apply to all existing blog posts that have that class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants