-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate private keys from the rest of the config #52
Labels
enhancement
New feature or request
Comments
It honestly might be a good idea to write the accounts explicitly, but to check the private keys against the supplied accounts, to avoid errors. Also the private keys should probably be providable separately from the config file (probably via environment variables? a I'm changing the title of this issue to reflect this. |
norswap
changed the title
Derive accounts from keys
Separate private keys from the rest of the config
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we have a bunch of configuration options for accounts and private key.
This is super redundant: the accounts can be derived from the private keys, and by default we should do this derivation.
We can still allow accounts to be specified as a safety option, in which case, we will verify that the account & key match.
To do this we should install & use the eth_account python package.
The text was updated successfully, but these errors were encountered: